1. Forum
  2. DOVE-Net
  3. Synchronet Programming

  • src/syncterm/ssh.c

    From Deucе@VERT to Git commit to main/sbbs/master on Fri Jan 3 10:35:27 2025
    https://gitlab.synchro.net/main/sbbs/-/commit/e15ba30749ace18e46675ec4
    Modified Files:
    src/syncterm/ssh.c
    Log Message:
    Move ssh_complete out of ssh_mutex

    Coverity seems to hate it mostly in the mutex, so change it to
    mostly outside of the mutex and see if that's fine.

    It doesn't really matter where it's changed as it's an atomic bool.

    ---
    ￭ Synchronet ￭ Vertrauen ￭ Home of Synchronet ￭ [vert/cvs/bbs].synchro.net
  • From Deucе@VERT to Git commit to main/sbbs/master on Sat Jan 4 22:55:27 2025
    https://gitlab.synchro.net/main/sbbs/-/commit/1326b624bd973b8e3f6e9b93
    Modified Files:
    src/syncterm/ssh.c
    Log Message:
    Fix memory leak when connection lost during SFTP key check

    Found by scan-build

    ---
    ￭ Synchronet ￭ Vertrauen ￭ Home of Synchronet ￭ [vert/cvs/bbs].synchro.net
  • From Deucе@VERT to Git commit to main/sbbs/master on Tue Jan 7 13:13:00 2025
    https://gitlab.synchro.net/main/sbbs/-/commit/ee15f3cfe79bf6f5f0486f3e
    Modified Files:
    src/syncterm/ssh.c
    Log Message:
    Remove more redundant code

    ssh_active was never set to false anymore
    channel_gone did exactly the same thing as conn_api.terminate
    change read/write timeouts to zero when closing

    ---
    ￭ Synchronet ￭ Vertrauen ￭ Home of Synchronet ￭ [vert/cvs/bbs].synchro.net
  • From Deucе@VERT to Git commit to main/sbbs/master on Tue Jan 7 13:16:42 2025
    https://gitlab.synchro.net/main/sbbs/-/commit/0ad896e3b34767ba64207875
    Modified Files:
    src/syncterm/ssh.c
    Log Message:
    Remove likely obsolete Coverity suppression.

    It can be added back if the issue reappears.

    ---
    ￭ Synchronet ￭ Vertrauen ￭ Home of Synchronet ￭ [vert/cvs/bbs].synchro.net